Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radar-rest-sources-authorizer] Use default authUrl #226

Closed
wants to merge 1 commit into from

Conversation

pvannierop
Copy link
Collaborator

@pvannierop pvannierop commented Jul 18, 2024

Problem

By default, the rest-sources-authorizer would use localhost/managementportal/auth as authorization URL.

Solution

The application will use https://serverName/managementportal/oauth as default authUrl. A custom authUrl can be provided via the values.md file.

@pvannierop pvannierop requested a review from keyvaann July 18, 2024 12:22
Copy link

github-actions bot commented Jul 18, 2024

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pvannierop pvannierop force-pushed the feature/configure-authUrl-rest-authorizer branch from 074f5e6 to d77cc59 Compare July 23, 2024 07:22
@pvannierop pvannierop force-pushed the feature/configure-authUrl-rest-authorizer branch from d77cc59 to 9ee9de4 Compare July 23, 2024 07:23
@pvannierop pvannierop closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants