Notify when storage is 75% and when it is full. #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.2.1
Release 1.2.2
|
fixes issue #141 |
blootsvoets
reviewed
May 3, 2023
radar-commons-android/src/main/java/org/radarbase/android/util/StorageLevelReceiver.kt
Outdated
Show resolved
Hide resolved
radar-commons-android/src/main/java/org/radarbase/android/util/StorageLevelReceiver.kt
Outdated
Show resolved
Hide resolved
radar-commons-android/src/main/java/org/radarbase/android/util/StorageLevelReceiver.kt
Outdated
Show resolved
Hide resolved
radar-commons-android/src/main/java/org/radarbase/android/util/StorageLevelReceiver.kt
Outdated
Show resolved
Hide resolved
radar-commons-android/src/main/java/org/radarbase/android/data/TapeCache.kt
Outdated
Show resolved
Hide resolved
radar-commons-android/src/main/java/org/radarbase/android/data/TapeCache.kt
Outdated
Show resolved
Hide resolved
| @@ -123,6 +126,30 @@ abstract class SourceService<T : BaseSourceState> : LifecycleService(), SourceSt | |||
| sourceTypes = emptySet() | |||
| broadcaster = LocalBroadcastManager.getInstance(this) | |||
|
|
|||
| broadcaster.run{ | |||
There was a problem hiding this comment.
The intention here is good, but it's probably better put in RadarService -- only one notification should run at a time and probably the most urgent one (full) should be shown. In DataHandler you could keep a whole list of storageReceiver, one per DataCache, and if at least ONE of them becomes full, show a full notification. Otherwise, if at least ONE of them becomes partially full, show the other notification.
radar-commons-android/src/main/java/org/radarbase/android/data/DataHandlerConfiguration.kt
Show resolved
Hide resolved
|
Hi @blootsvoets is it what you are saying for? Or some other changes are required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Please review the attached pull request and provide your feedback.
Thanks