Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate resources by the cluster name #7

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

baixiac
Copy link
Member

@baixiac baixiac commented Dec 6, 2023

No description provided.

@keyvaann
Copy link
Collaborator

keyvaann commented Dec 6, 2023

Thanks @baixiac!
How does the upgrading process works with Terraform? Once this PR is merged, if I run plan and apply will everything be safely renamed to the new structure?

@baixiac
Copy link
Member Author

baixiac commented Dec 6, 2023

That will largely depend on the updating rules of TF modules and AWS SDK. Some resources allow you to update certain attributes without recreation. For others, e.g., If you change an S3 bucket name, a new bucket will be created and the old one will be deleted without data being copied across (needles to say this will fail if the old bucket is not empty). The best practice is always run terraform plan, review the diff/tf-ops and take necessary backup actions before applying the change.

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, since this is repository is alpha having breaking changes should be fine, otherwise we would have had to come up with a migration plan.

@baixiac baixiac merged commit 20e01e4 into main Dec 7, 2023
2 checks passed
@baixiac baixiac deleted the resource-naming branch December 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants