Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stack): add NetData to the stack, no auth yet #187

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

afolarin
Copy link
Member

@afolarin afolarin commented Feb 28, 2019

Started looking at server monitoring to the stack via NetData container #132

Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some security changes are probably needed (see comments). A general comment: it may make sense to have a separate stack (on a separate port, with a separate nginx instance) for these admin consoles. That would include kafka manager, portainer and netdata. This ensures that even if the RADAR stack is not working (e.g. one of the containers doesn't start), the dashboards are still active. If it is a single stack, Nginx will refuse to start if one of the containers is offline. It also splits up system privileged operations from regular operations, which is useful if the system has stringent user requirements.

It means that the kafka network would need to be external, to allow Kafka Manager to connect to the Kafka cluster.

@afolarin
Copy link
Member Author

afolarin commented Mar 4, 2019

A general comment: it may make sense to have a separate stack (on a separate port, with a separate nginx instance) for these admin consoles.

yes agreed. I'll round-up work on adding this then look to adding another proxy dedicated for utilities.

- Add basic auth using nginx for netdata.
- Fixes and changes based on PR comments.
yatharthranjan
yatharthranjan previously approved these changes Mar 19, 2019
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The breaking out of admin consoles can be done in a separate PR.
Thanks.

blootsvoets
blootsvoets previously approved these changes Mar 20, 2019
Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afolarin
Copy link
Member Author

afolarin commented Mar 20, 2019

LGTM. The breaking out of admin consoles can be done in a separate PR.
Thanks.

@blootsvoets suggestion a good one to refactor the monitoring services and route them separately

- /proc:/host/proc:ro
- /sys:/host/sys:ro
- /var/run/docker.sock:/var/run/docker.sock:ro
- ./etc/netdata/netdata.conf:/etc/netdata/netdata.conf:ro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only a few options are updated, You can also use command directive in docker-compose to supply the daemon opts listed here https://docs.netdata.cloud/daemon/#command-line-options to the container. In this case, it will be like -

...
command: -W set section option value -W set section2 option2 value
...

Coz i see most of the conf file is commented out anyways but the file is more than 40k lines

@nivemaham nivemaham dismissed stale reviews from blootsvoets and yatharthranjan via ac3c9c6 August 25, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants