Corrected Generation Of Entity Relationship Diagram #153

tslever · 2024-08-09T04:56:48Z

Specifically, I corrected inverted relationships following Christophe's comment on 08/05/2024 11:31:34Z at https://stackoverflow.com/questions/78776709/drawing-relationships-in-entity-relationship-diagram/78831819?noredirect=1#comment138990567_78831819.

Before I made these changes an Entity Relationship Diagram was

After I made these changes an Entity Relationship Diagram was

R0tenur

First of: big thanks for your contribution!

Project does not build in the CI anymore.

Why was switching from yarn to npm a part of this PR?
Why was debugging docs and frontend docs removed from the docs.md?
Why is docs.md now Windows specific?

R0tenur · 2024-08-09T09:06:54Z

docs/docs.md

- A recent version of node.js
- yarn or npm
+## Prerequisites For Generating vsix File
+- Windows 11 Home, Version 22H2, OS build 22621.3880, Windows Feature Experience Pack 1000.22700.1020.0


This is not true. I have never built this on a windows machine and the CI is running Linux.

@R0tenur , I removed this prerequisite.

R0tenur · 2024-08-09T09:10:42Z

docs/docs.md


-## Installation
-In a terminal:
+In Git Bash, ensure you are using Node.js version 20.16.0 by running `node --version`.


Why Windows specific? Data studio is platform independent

@R0tenur , I generalized docs/docs.md from being Windows specific.

R0tenur · 2024-08-09T09:14:16Z

docs/docs.md

-
-This will generate an vsix that can be installed in azure data studio.
-
-## Debug


Why removing info about debugging and frontend dev?

@R0tenur , I restored info about debugging and using your front end.

R0tenur · 2024-08-09T13:16:46Z

backend/src/services/builder.service.ts

  }

-  if (column.constraints.includes("UNIQUE")) {


includes has better readability

@R0tenur , I used includes instead of indexOf after getting everything working.

tslever · 2024-08-09T15:28:10Z

@R0tenur , hopefully changes relating to creating our vsix file on Linux will satisfy your Continuous Integration. Hopefully changes to docs/docs.md will address your concerns.

I restored documentation relating to using yarn to create our vsix file.

I restored your sections on debugging and using your front end.

docs/docs.md is no longer Windows specific.

…ntax/entityRelationshipDiagram.html#relationship-syntax

tslever · 2024-08-09T18:43:48Z

@R0tenur , you can see a passing GitHub action at https://github.com/tslever/Generator_Of_ERDs/actions .

R0tenur

yarn.lock are lock files for yarn and package-lock.json are lock files for npm.
Since project is using yarn the package-lock files should not be included.

Other than this I think ot looks all fine!

tslever · 2024-08-10T15:43:46Z

@R0tenur , I have deleted files named package-lock.json.

R0tenur

Doc stuff that are to specific

R0tenur · 2024-08-10T16:15:20Z

docs/docs.md

+
+Click the ellipsis and Install from VSIX...
+
+Install file `Generator_Of_ERDs/backend/schema-visualization-0.9.3.vsix`.


One last thing: "Generator_Of_ERDs" seem to be the name of your fork.

Also the 0.9.3 is the version number that will vary each time

@R0tenur , I referenced a generalized path to the vsix file in an earlier part of docs.md.

R0tenur · 2024-08-10T16:16:02Z

docs/docs.md

+
+Run `npm run pack`.
+
+Move `schema-visualization-0.9.3.vsix` to a desired location for installation as an extension in Azure Data Studio.


0.9.3 is version that will vara each time

@R0tenur , I put a generalized path to the vsix file here.

sonarcloud · 2024-08-11T02:21:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

andreasmarxer · 2024-08-19T18:44:22Z

First thanks for this fix and update!

I would be really interested in this correction of the directions, but after updating from V0.9.1 to the latest version V0.9.4 I receive an error and the diagram generation is not anymore working:
Error loading webview: Error: Could not register service worker: InvalidStateError: Failed to register a ServiceWorker: The document is in an invalid state..

@R0tenur @tslever

Anyone also experiencing this with v0.9.4 or any ideas what could be the issue on my side?

tslever · 2024-09-07T05:33:15Z

@andreasmarxer , hi. You're welcome. Thanks to @R0tenur also.
I am able to generate an ERD.
See ./docs/docs.md.
I again cloned this repository, regenerated the extension using Git Bash and npm, and reinstalled the extension.
I recall ensuring Continuous Integration using Windows Subsystem for Linux and the GitHub Action of my fork of this repository.
Before regenerating the extension, to avoid experiencing dependency hell again, I downloaded the package-lock.json files that I deleted toward the end of my work per @R0tenur's request.

andreasmarxer · 2024-09-16T18:08:58Z

Hi @tslever
Thanks for the reply and sorry for the misunderstanding.

I did not build the visx package by my own, I did jsut take the latest version v0.9.4 available in the builds, which should include this change as well. But I will in this case give it a try to generate the visx package locally on my machine.

tslever · 2024-09-16T23:22:52Z

@andreasmarxer , I noticed that this pull request is closed. Would you please create a pull request with a new build available in the appropriate location?

tslever added 2 commits August 8, 2024 23:37

Corrected inverted relationships

a0e1140

Generated correct Entity Relationship Diagram

e4ece3d

tslever mentioned this pull request Aug 9, 2024

Wrong relation direction #138

Closed

R0tenur requested changes Aug 9, 2024

View reviewed changes

R0tenur reviewed Aug 9, 2024

View reviewed changes

Used Linux to generate vsix file / extension to generate ERDs

3e9a724

tslever added 4 commits August 9, 2024 11:44

Used includes instead of indexOf and improved docs

6b318fd

Possibly corrected inverted cardinality per https://mermaid.js.org/sy…

0dd84c7

…ntax/entityRelationshipDiagram.html#relationship-syntax

Removed backend/yarn.lock to allow CI

51d0f4a

Updated TypeScript and VSCode types

24241f3

tslever force-pushed the master branch from bff4a5d to 24241f3 Compare August 9, 2024 17:51

Revised tests of relationships

c249f15

R0tenur reviewed Aug 10, 2024

View reviewed changes

Deleted files named package-lock.json

62acb08

R0tenur requested changes Aug 10, 2024

View reviewed changes

Update docs.md

638f483

R0tenur merged commit db2e990 into R0tenur:master Aug 11, 2024
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Corrected Generation Of Entity Relationship Diagram #153

Corrected Generation Of Entity Relationship Diagram #153

tslever commented Aug 9, 2024 •

edited

Loading

R0tenur left a comment •

edited

Loading

R0tenur Aug 9, 2024

tslever Aug 9, 2024 •

edited

Loading

R0tenur Aug 9, 2024

tslever Aug 9, 2024

R0tenur Aug 9, 2024

tslever Aug 9, 2024

R0tenur Aug 9, 2024

tslever Aug 9, 2024

tslever commented Aug 9, 2024

tslever commented Aug 9, 2024

R0tenur left a comment •

edited

Loading

tslever commented Aug 10, 2024

R0tenur left a comment

R0tenur Aug 10, 2024

tslever Aug 11, 2024 •

edited

Loading

R0tenur Aug 10, 2024

tslever Aug 11, 2024 •

edited

Loading

sonarcloud bot commented Aug 11, 2024

andreasmarxer commented Aug 19, 2024 •

edited

Loading

tslever commented Sep 7, 2024 •

edited

Loading

andreasmarxer commented Sep 16, 2024

tslever commented Sep 16, 2024


		This will generate an vsix that can be installed in azure data studio.

		## Debug


		Click the ellipsis and Install from VSIX...

		Install file `Generator_Of_ERDs/backend/schema-visualization-0.9.3.vsix`.


		Run `npm run pack`.

		Move `schema-visualization-0.9.3.vsix` to a desired location for installation as an extension in Azure Data Studio.

Corrected Generation Of Entity Relationship Diagram #153

Corrected Generation Of Entity Relationship Diagram #153

Conversation

tslever commented Aug 9, 2024 • edited Loading

R0tenur left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tslever Aug 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tslever commented Aug 9, 2024

tslever commented Aug 9, 2024

R0tenur left a comment • edited Loading

Choose a reason for hiding this comment

tslever commented Aug 10, 2024

R0tenur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tslever Aug 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tslever Aug 11, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Aug 11, 2024

Quality Gate passed

andreasmarxer commented Aug 19, 2024 • edited Loading

tslever commented Sep 7, 2024 • edited Loading

andreasmarxer commented Sep 16, 2024

tslever commented Sep 16, 2024

tslever commented Aug 9, 2024 •

edited

Loading

R0tenur left a comment •

edited

Loading

tslever Aug 9, 2024 •

edited

Loading

R0tenur left a comment •

edited

Loading

tslever Aug 11, 2024 •

edited

Loading

tslever Aug 11, 2024 •

edited

Loading

andreasmarxer commented Aug 19, 2024 •

edited

Loading

tslever commented Sep 7, 2024 •

edited

Loading