Fix NPE when non-BlockEntity calls AbstractFurnaceBlockEntity#craftRecipe
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OroArmor
requested changes
Aug 24, 2023
...item_setting/src/main/java/org/quiltmc/qsl/item/setting/api/RecipeRemainderLogicHandler.java
Outdated
Show resolved
Hide resolved
...ava/org/quiltmc/qsl/item/setting/mixin/recipe_remainder/AbstractFurnaceBlockEntityMixin.java
Outdated
Show resolved
Hide resolved
EnnuiL
suggested changes
Aug 25, 2023
EnnuiL
added
library: item
OroArmor
approved these changes
Aug 28, 2023
EnnuiL
approved these changes
Aug 29, 2023
EnnuiL
changed the title
AbstractFurnaceBlockEntity#craftRecipe
|
This PR has entered a Final Comment Period of 5 days on August 31st, with 3 days remaining now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If smelting is performed from a non-in-world "furnace" (e.g. portable furnace from PortableTables), the ThreadLocal used for remainder item overflow dropping may be null, or may correspond to the location of a different in-world furnace.
The getting of the BE from the ThreadLocal has been moved so it happens during the actual dropping of the items, to prevent accessing the ThreadLocal when items don't need dropping.
Since the position is not needed if there are no overflowing remainder items, the recipe output mixin will check if there is no BE performing the smelting and if there would be a remainder that cannot fit, and in that situation, prevents the output from accepting more items.
Draft because not sure if the additional API method is desirable or not.