-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReactiveSwift tests #3
base: master
Are you sure you want to change the base?
Conversation
Wow, amazing! I will take a look and also update the statistics before I merge it. Will then also include the numbers file, so that everyone can update the graphics as well. |
Not sure, I was as surprised as you are. I've opened a discussion on ReactiveSwift Slack if it is really that slow or the tests don't do what thay should (but I honestly doubt that) |
Hmm ok. I would be ready to merge it, but I would prefer waiting for a response to your question in the slack channel. Maybe you can also ask in an issue on github as well. |
Well the only answer I got so far is link to Twitter thread you are part of 🤷♂️ I’ll file an issue |
Judging by the benchmark, I see a logical pattern here:
With (2), I can see how it can snowball into a significant deficit. Nonetheless, it would still be an interesting performance case to look into. |
Hi,
as I usually use ReactiveSwift I thought it would be great to add it to the comparison as well.