-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visionOS support #1098
Merged
younata
merged 20 commits into
Quick:main
from
bitmovin-engineering:bitmovin/feature/visionos-support
Jan 17, 2024
Merged
Add visionOS support #1098
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4c69024
add compiler directives for visionOS support
stonko1994 0f901d9
add SPM visionOS support
stonko1994 d3eebfd
add CocoaPods visionOS support
stonko1994 8663e72
update Carthage dependencies
stonko1994 a594e61
add visionOS support when using the Xcode project
stonko1994 f0fb4c4
extend test script to include visionOS
stonko1994 3720617
fix cocoapods support by modifying dependencies directly
stonko1994 78b4e76
do not break older Swift version support by creating a swift 5.9 expl…
stonko1994 b86604f
skip tests on visionOS if it's not present
stonko1994 a8d72dd
fix build issues below Xcode 15
stonko1994 00d6003
skip visionOS cocoapod validation if visionOS is not present
stonko1994 5cf19ca
move TARGET_OS_VISION definition to umbrella header
stonko1994 3ff34fc
bump CwlPreconditionTesting to 2.2.0
stonko1994 9ed8094
Merge branch 'main' into bitmovin/feature/visionos-support
stonko1994 1972142
link CwlPreconditionTesting on visionOS
stonko1994 c08b060
add visionOS for to dependencies array
stonko1994 eaac8f4
Merge branch 'main' into bitmovin/feature/visionos-support
stonko1994 11c9bc7
Merge branch 'main' into bitmovin/feature/visionos-support
stonko1994 9eaf3be
add CI execution for visionOS with Xcode 15.2
stonko1994 6eb5881
remove visionOS testing on Xcode 15.2
stonko1994 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,23 @@ | ||
{ | ||
"object": { | ||
"pins": [ | ||
{ | ||
"package": "CwlCatchException", | ||
"repositoryURL": "https://github.com/mattgallagher/CwlCatchException.git", | ||
"state": { | ||
"branch": null, | ||
"revision": "f809deb30dc5c9d9b78c872e553261a61177721a", | ||
"version": "2.0.0" | ||
} | ||
}, | ||
{ | ||
"package": "CwlPreconditionTesting", | ||
"repositoryURL": "https://github.com/mattgallagher/CwlPreconditionTesting.git", | ||
"state": { | ||
"branch": null, | ||
"revision": "c21f7bab5ca8eee0a9998bbd17ca1d0eb45d4688", | ||
"version": "2.1.0" | ||
} | ||
"pins" : [ | ||
{ | ||
"identity" : "cwlcatchexception", | ||
"kind" : "remoteSourceControl", | ||
"location" : "https://github.com/mattgallagher/CwlCatchException.git", | ||
"state" : { | ||
"revision" : "3b123999de19bf04905bc1dfdb76f817b0f2cc00", | ||
"version" : "2.1.2" | ||
} | ||
] | ||
}, | ||
"version": 1 | ||
}, | ||
{ | ||
"identity" : "cwlpreconditiontesting", | ||
"kind" : "remoteSourceControl", | ||
"location" : "https://github.com/mattgallagher/CwlPreconditionTesting.git", | ||
"state" : { | ||
"revision" : "dc9af4781f2afdd1e68e90f80b8603be73ea7abc", | ||
"version" : "2.2.0" | ||
} | ||
} | ||
], | ||
"version" : 2 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
// swift-tools-version:5.9 | ||
import PackageDescription | ||
|
||
let package = Package( | ||
name: "Nimble", | ||
platforms: [ | ||
.macOS(.v10_15), .iOS(.v13), .tvOS(.v13), .watchOS(.v6), .visionOS(.v1) | ||
], | ||
products: [ | ||
.library( | ||
name: "Nimble", | ||
targets: { | ||
var targets: [String] = ["Nimble"] | ||
#if os(macOS) | ||
targets.append("NimbleObjectiveC") | ||
#endif | ||
return targets | ||
}() | ||
), | ||
], | ||
dependencies: [ | ||
.package(url: "https://github.com/mattgallagher/CwlPreconditionTesting.git", .upToNextMajor(from: "2.2.0")), | ||
], | ||
targets: { | ||
var testHelperDependencies: [PackageDescription.Target.Dependency] = ["Nimble"] | ||
#if os(macOS) | ||
testHelperDependencies.append("NimbleObjectiveC") | ||
#endif | ||
var targets: [Target] = [ | ||
.target( | ||
name: "Nimble", | ||
dependencies: [ | ||
.product(name: "CwlPreconditionTesting", package: "CwlPreconditionTesting", | ||
condition: .when(platforms: [.macOS, .iOS, .macCatalyst, .visionOS])), | ||
.product(name: "CwlPosixPreconditionTesting", package: "CwlPreconditionTesting", | ||
condition: .when(platforms: [.tvOS, .watchOS])) | ||
], | ||
exclude: ["Info.plist"] | ||
), | ||
.target( | ||
name: "NimbleSharedTestHelpers", | ||
dependencies: testHelperDependencies | ||
), | ||
.testTarget( | ||
name: "NimbleTests", | ||
dependencies: ["Nimble", "NimbleSharedTestHelpers"], | ||
exclude: ["Info.plist"] | ||
), | ||
] | ||
#if os(macOS) | ||
targets.append(contentsOf: [ | ||
.target( | ||
name: "NimbleObjectiveC", | ||
dependencies: ["Nimble"] | ||
), | ||
.testTarget( | ||
name: "NimbleObjectiveCTests", | ||
dependencies: ["NimbleObjectiveC", "Nimble", "NimbleSharedTestHelpers"] | ||
) | ||
]) | ||
#endif | ||
return targets | ||
}(), | ||
swiftLanguageVersions: [.v5] | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was added to not break support for older Swift versions.
See details about this here: https://www.polpiella.dev/version-specific-package-manifests