Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PG::ConnectionBad issue #312

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Fix PG::ConnectionBad issue #312

merged 1 commit into from
Oct 18, 2019

Conversation

ukd1
Copy link
Contributor

@ukd1 ukd1 commented Jul 18, 2019

Checking out the fixes @siegy22 did related to #302.

Let's lazy use the ActiveRecord::Base.connection.raw_connection.

Let's lazy use the ActiveRecord::Base.connection.raw_connection.
@ukd1 ukd1 added this to the 4.0.0 milestone Jul 23, 2019
Copy link

@bwlang bwlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working in my hands (had the problem before the patch, working now)

gem 'rails', git: 'https://github.com/rails/rails.git', branch: '6-0-stable'
gem 'queue_classic', github: 'siegy22/queue_classic', branch: 'master'

@siegy22
Copy link

siegy22 commented Jul 25, 2019

The tests need to be adjusted tho, didn't do that yet. And it's a breaking API change of the ConnAdapter, so this should definitely land in a major release 😄

@siegy22
Copy link

siegy22 commented Jul 25, 2019

And thanks for your effort @ukd1, I'm here if you need some help.

@ukd1 ukd1 merged commit 523cd7c into QueueClassic:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants