[finite_markov] notational changes #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstac
reviewed
May 6, 2020
source/rst/finite_markov.rst
Outdated
| @@ -1483,7 +1484,7 @@ Exercise 2 | |||
| from operator import itemgetter | |||
|
|
|||
| infile = 'web_graph_data.txt' | |||
| alphabet = 'abcdefghijklmnopqrstuvwxyz' | |||
| lambdabet = 'abcdefghijklmnopqrstuvwxyz' | |||
There was a problem hiding this comment.
please fix this and other examples of "alphabet" below.
sayaikegawa
reviewed
May 8, 2020
source/rst/finite_markov.rst
Outdated
| @@ -1343,7 +1344,7 @@ The following code snippet provides a hint as to how you can go about this | |||
| .. code-block:: python3 | |||
|
|
|||
| import re | |||
| re.findall('\w', 'x +++ y ****** z') # \w matches alphanumerics | |||
| re.findall('\w', 'x +++ y ****** z') # \w matches lambdanumerics | |||
|
|
|||
There was a problem hiding this comment.
Hi @Harveyt47 , here also should be changed to "alphanumerics"?
There was a problem hiding this comment.
Hi @sayaikegawa yes I'll make a the change. Thanks @sayaikegawa.
Harveyt47
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jstac
This is the notational change in finite markov of #51 .
I changed the notation of \alpha -> \lambda, \beta -> \alpha and \lambda -> \pi.
I have also clarified that here beta is a discount factor.