Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to lake model lecture required #51

Open
jstac opened this issue Dec 2, 2019 · 7 comments
Open

Updates to lake model lecture required #51

jstac opened this issue Dec 2, 2019 · 7 comments
Assignees
Labels

Comments

@jstac
Copy link
Contributor

jstac commented Dec 2, 2019

Endogenous flows need to be brought up to date with changes in QuantEcon/lecture-source-py#793.

@jstac jstac self-assigned this Dec 2, 2019
@shlff shlff transferred this issue from QuantEcon/lecture-source-py Mar 26, 2020
@Harveyt47 Harveyt47 self-assigned this Apr 23, 2020
@Harveyt47
Copy link
Member

Harveyt47 commented Apr 23, 2020

Point of possible confusion.

d is used in McCall for the expected value of unemployment tomorrow,

while in lake model d is used to denote labour market exit rate.

@Harveyt47
Copy link
Member

in lake u is used to denote both unemployment rate and the utility function

@Harveyt47
Copy link
Member

Harveyt47 commented Apr 23, 2020

Change links to McCall model to McCall search and separation model. I think the search lecture is more connected than McCall 1.

@Harveyt47
Copy link
Member

Move utility function and update_bellman function into MccallModel class and jitclass the class.

Also make sure variables are consistent across lectures.

split MccallModel and solve_mccall_model into different cells.

@Harveyt47
Copy link
Member

I think at minimum we should do the following which can be found in this notebook.

Main changes are in endogenous flow section

I also add a random_state=seed in the markov chain [simulation] (https://python-intro.quantecon.org/lake_model.html#Convergence-Rate)

CC @shlff @mtiley @sayaikegawa if you guys have time to look over this issue and discuss changes.

I have left out any changes to variables and their notation. Discussion of consistence of variable notation across lake model and McCall model is needed.

@Harveyt47
Copy link
Member

@sayaikegawa and I have discussed a number of changes to be made not only to the lake model but other lectures to maintain notational consistency.

Finite Markov changes

  • change \alpha -> \lambda
  • change \beta -> \alpha
  • change \lambda -> \pi here
    Job Search 2 changes
  • change d -> f
    Lake Model changes
  • remove @property from class
  • change sentences above the class regarding @property.
  • add code in this notebook to here
  • change exercise to account of class changes

@jstac
Copy link
Contributor Author

jstac commented May 5, 2020

Sounds good guys, looking forward to seeing the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants