[prob_dist] Fix a small bug in prob_dist
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for playful-platypus-17d3bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
There is a small bug in |
mmcky
reviewed
Oct 25, 2024
There was a problem hiding this comment.
@HumphreyYang are you removing the countries not used in our analysis. Would the more general concordance be useful in other lectures down the track? I would be in favour of leaving the dataset large.
|
thanks @HumphreyYang |
HumphreyYang
changed the title
prob_dist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mmcky,
This PR fixes a small bug in
prob_distand is trying to cut some countries/regions from the country code translation dataset so that it's easier to find countries. We can add more countries/regions if they appear in our lecture.