Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Don't link to StackOverflow #211

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Don't link to StackOverflow #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cff0546
Don't link to StackOverflow
Eric-Arellano Mar 14, 2023
f06b84f
Add changeset
Eric-Arellano Mar 16, 2023
4ea82b6
Remove Slack from the top menu too
Eric-Arellano Mar 17, 2023
80b4f0c
Remove Slack from the top menu too
Eric-Arellano Mar 17, 2023
7439bd2
Merge branch 'stack-overflow' of https://github.com/Eric-Arellano/web…
Eric-Arellano Mar 17, 2023
bcbcf0a
Merge branch 'main' into stack-overflow
Eric-Arellano Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/remove-stack-overflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@qiskit/web-components': patch
---

Remove StackOverflow link from footer and ui-shell Documentation dropdown menu.
Also remove Slack from the ui-shell dropdown menu.
4 changes: 2 additions & 2 deletions components/footer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ export class QiskitFooter extends LitElement {
url: 'https://github.com/Qiskit',
},
{
label: 'Stack Exchange',
url: 'https://quantumcomputing.stackexchange.com/questions/tagged/qiskit',
label: 'Support Channels',
url: 'https://qisk.it/support',
},
{
label: 'Documentation',
Expand Down
8 changes: 2 additions & 6 deletions components/ui-shell/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,17 +186,13 @@ export const NAV_ITEMS: TopLevelNavItem[] = [
label: 'Help and Learning',
children: [
{
label: 'Stack Exchange',
url: 'https://quantumcomputing.stackexchange.com/questions/tagged/qiskit',
label: 'Support Channels',
url: 'https://qisk.it/support',
Comment on lines -189 to +190
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support channels page contain information about Slack as well. Should we remove the Slack link in this drop down menu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that too. I think it depends how much we want people going to Slack? For Pantsbuild, that was a huge project priority so we referenced Slack everywhere like blog posts. Even if it was repetitive like this here would be.

For Qiskit, how much do want to specifically funnel people to Slack? If we want to, then I think it's worth repeating. Otherwise, we could probably remove.

The benefit of removing would be less text in the top nav bar, I suppose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the benefits of removing it is so that people will read the information about different slack channels and where to get help for specific issues, similar to the spirit of this PR trying to guide people to read about what kind of questions should go to StackExchange instead of sending people there directly.

},
{
label: 'Qiskit Feedback',
url: 'https://github.com/Qiskit/feedback',
},
{
label: 'Slack',
url: 'https://qisk.it/join-slack',
},
{
label: 'Qiskit Textbook',
url: 'https://qiskit.org/learn/',
Expand Down