Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support new files #1546

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Add support new files #1546

merged 5 commits into from
Dec 10, 2024

Conversation

korgan00
Copy link
Collaborator

@korgan00 korgan00 commented Dec 3, 2024

Summary

Add support for the new files list method in the client

Details and comments

@Tansito
Copy link
Member

Tansito commented Dec 3, 2024

@korgan00 can you put data-folder branch as base? In main you are not going to have the required end-points to pass the tests

@korgan00 korgan00 changed the base branch from main to data-folder December 3, 2024 15:31
@Tansito
Copy link
Member

Tansito commented Dec 3, 2024

@korgan00 I just saw too that your branch is based on main. You will need to apply a rebase if you can over data-folder. We can take a look to it Monday if you want.

@korgan00 korgan00 force-pushed the client/add-support-new-files branch from 2d2a8a6 to 17661ca Compare December 9, 2024 15:19
@korgan00 korgan00 force-pushed the client/add-support-new-files branch from 17661ca to 5113dd6 Compare December 9, 2024 16:01
@Tansito Tansito self-requested a review December 10, 2024 19:31
Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @korgan00 🎉

@Tansito Tansito merged commit 19d9602 into data-folder Dec 10, 2024
7 checks passed
@Tansito Tansito deleted the client/add-support-new-files branch December 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants