Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GITHUB_TOKEN, default branch based and simplified periodically check process #500

Merged
merged 29 commits into from
Aug 21, 2023

Conversation

mickahell
Copy link
Collaborator

@mickahell mickahell commented Aug 19, 2023

Summary

Replace custom token with GITHUB_TOKEN and main branch with default checkout branch.
Simplified the periodically check process.

Details and comments


Closes #496

mickahell and others added 22 commits July 27, 2023 18:44
* force string for output

* Revert "force string for output"

This reverts commit cabecb9.

* make stable and dev check informational + badge good when only standard

* set messages

* update unit tests

* lint

* lint

* fork doesn't sync

* fork sync

* Update .github/workflows/ecosystem-submission.yml

Co-authored-by: Frank Harkins <[email protected]>

Co-authored-by: Frank Harkins <[email protected]>

* add assert for set_actions_output
Co-authored-by: Frank Harkins <[email protected]>

* Revert "add assert for set_actions_output"

This reverts commit 51c0f56.

* Update .github/workflows/ecosystem-submission.yml

Co-authored-by: Frank Harkins <[email protected]>

* Update .github/workflows/ecosystem-submission.yml

Co-authored-by: Frank Harkins <[email protected]>

* no regex in actions if

* clear condition

---------

Co-authored-by: Frank Harkins <[email protected]>
Badges and stars update
Time: 2023_08_02_13_46

Co-authored-by: frankharkins <[email protected]>
@mickahell mickahell marked this pull request as draft August 19, 2023 10:32
@mickahell mickahell self-assigned this Aug 19, 2023
@mickahell mickahell added the bug Something isn't working label Aug 19, 2023
@mickahell mickahell marked this pull request as ready for review August 19, 2023 11:53
@mickahell mickahell requested a review from frankharkins August 19, 2023 11:53
@mickahell
Copy link
Collaborator Author

@frankharkins ready for your review :)

It has a bit more than just the token, I simplified the process and clean some CI

@mickahell mickahell changed the title Use GITHUB_TOKEN and default branch based Use GITHUB_TOKEN, default branch based and simplified periodically check tests process Aug 19, 2023
@mickahell mickahell changed the title Use GITHUB_TOKEN, default branch based and simplified periodically check tests process Use GITHUB_TOKEN, default branch based and simplified periodically check process Aug 19, 2023
@mickahell mickahell added the enhancement New feature or request label Aug 19, 2023
@mickahell mickahell requested a review from frankharkins August 20, 2023 18:59
Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The action looks neater too 😄

@frankharkins frankharkins merged commit b6710c2 into Qiskit:main Aug 21, 2023
@mickahell mickahell deleted the bug/actions-token branch August 21, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Use default Actions token for wf triggering
2 participants