-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add labels to issue and PR and improve output from submission wf #481
CI: Add labels to issue and PR and improve output from submission wf #481
Conversation
This reverts commit cabecb9.
Co-authored-by: Frank Harkins <[email protected]>
This reverts commit 51c0f56.
@frankharkins ready for your review :) I also implemented a new comment structured using the GitHub step summary. That's allow to simplify the code and have more clear output :) All the examples :
(the 2 errors in the annotations are normal it's because I'm asking to delete labels who aren't on the issue, I added a |
* force string for output * Revert "force string for output" This reverts commit cabecb9. * make stable and dev check informational + badge good when only standard * set messages * update unit tests * lint * lint * fork doesn't sync * fork sync * Update .github/workflows/ecosystem-submission.yml Co-authored-by: Frank Harkins <[email protected]> Co-authored-by: Frank Harkins <[email protected]> * add assert for set_actions_output Co-authored-by: Frank Harkins <[email protected]> * Revert "add assert for set_actions_output" This reverts commit 51c0f56. * Update .github/workflows/ecosystem-submission.yml Co-authored-by: Frank Harkins <[email protected]> * Update .github/workflows/ecosystem-submission.yml Co-authored-by: Frank Harkins <[email protected]> * no regex in actions if * clear condition --------- Co-authored-by: Frank Harkins <[email protected]>
Badges and stars update Time: 2023_08_02_13_46 Co-authored-by: frankharkins <[email protected]>
71334fc
to
e20f586
Compare
The long line of commits was because I had to amended a commit from GitHub action ^^' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great, thanks!
Only problem is I think a couple of steps are duplicated. I've also suggested some name / comment changes to make things clearer at a glance.
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Co-authored-by: Frank Harkins <[email protected]>
Yep @frankharkins I took your feedbacks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to request more changes. I now understand there's a separate step for each label addition/removal; it might be clearer to combine these eight steps into two steps.
That is, this pattern
if condition:
do x
do y
do z
rather than this one
if condition
do x
if condition
do y
if condition
do z
Then there should be less code and it should be harder to miss something when modifying the action.
Hmm ok I see what you mean, I'm not sure I can merge stps together. I'l check that |
Can you just put all the code in the same script? E.g. with:
script: |
github.rest.issues.addLabel({
...
})
github.rest.issues.removeLabel({
...
}) |
Totally ! I was somewhere else and totally forget I can merge script together ^^'
Don't worry that's totally ok :) Done, I mixed them. You can review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Summary
Add labels to issue and PR from submission wf.
Improve the wf output.
Details and comments
submission
label to every submission issue and PRon hold
label to every submission issue and PR who doesn't pass the standard checkon hold
label if the submission passedready
label to every submission issue and PR who passed the standard checkready
label if the submission doesn't passed anymoreCloses #480