Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): ensure tutorial sessions #633

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Dec 4, 2024

Description

The tutorial natives still seem to be causing issues as we're still getting reports of people unable to see other players. This edit forces the script to wait until the player is in or out of the session before it continues. I've tested this on local but not with other players.

I'm unsure why we're having such a hard time with these TutorialSession natives as ox_core uses them perfectly fine.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test this or get someone else to test this in a multiplayer environment to make sure this fixes the issue or otherwise revert back to using buckets.

@Manason Manason requested review from solareon and D4isDAVID December 4, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants