refactor: enhance draw text functiones for better flexibility #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed `scale` parameter in `qbx.drawText3d` to be a `vec2` with a default value of `vec2(0.35, 0.35)`, while maintaining backwards compatibility with the previous version - Introduced `disableDropShadow` and `disableOutline` parameters in `qbx.drawText2d` - Introduced `enableDropShadow` and `enableOutline` parameters in `qbx.drawText3d` - Added a warning for users using a number value as the scale parameter in `qbx.drawText3d`, encouraging the use of a `vec2` instead.
- Changed `scale` parameter in `qbx.drawText3d` to be a `vec2` with a default value of `vec2(0.35, 0.35)`, while maintaining backwards compatibility with the previous version - Introduced `disableDropShadow` and `disableOutline` parameters in `qbx.drawText2d` - Introduced `enableDropShadow` and `enableOutline` parameters in `qbx.drawText3d` - Added a warning for users using a number value as the scale parameter in `qbx.drawText3d`, encouraging the use of a `vec2` instead. - Fixed line 352 and 356 having trailing whitespaces
- Changed `scale` parameter in `qbx.drawText3d` to be a `vec2` with a default value of `vec2(0.35, 0.35)`, while maintaining backwards compatibility with the previous version - Introduced `disableDropShadow` and `disableOutline` parameters in `qbx.drawText2d` - Introduced `enableDropShadow` and `enableOutline` parameters in `qbx.drawText3d` - Added a warning for users using a number value as the scale parameter in `qbx.drawText3d`, encouraging the use of a `vec2` instead. - Fixed line 352 and 356 having trailing whitespaces
Manason
requested changes
Nov 2, 2024
Manason
approved these changes
Nov 3, 2024
Manason
approved these changes
Nov 3, 2024
Manason
approved these changes
Nov 4, 2024
|
@Manason just a quick question, do I need a second reviewer to review before it can be merged? Or can it be merged by just you giving it a review? |
A second reviewer is required. |
mafewtm
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scaleparameter inqbx.drawText3dto be avec2with a default value ofvec2(0.35, 0.35), while maintaining backwards compatibility with the previous versiondisableDropShadowanddisableOutlineparameters inqbx.drawText2denableDropShadowandenableOutlineparameters inqbx.drawText3dqbx.drawText3d, encouraging the use of avec2instead.Checklist