-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Thorlabs DotNetAPI #386
Open
DCEM
wants to merge
35
commits into
QCoDeS:main
Choose a base branch
from
Geowissenschaften:add-Thorlabs-DotNetAPI
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… decimal-to-float conversions - Introduce a new constructor argument `decimal_as_float` to toggle .NET Decimal conversion to either Python Decimal or float. - Refactor getter/setter methods to distinguish between DIRECT and ACCESSOR API interface usage with reflection. - Migrate from string-based .NET Enum handling to integer-based handling (verifying Int32 underpinnings). - Add `_get_thorlabs_enum_dict` to generate a QCoDeS-friendly dictionary for enum names and values. - Use `CultureInfo.InvariantCulture` for .NET Decimal to string conversion to ensure consistent locale handling. - Improve validation and error handling throughout the mixin to guard against incorrect usage and data type mismatches.
Untested with sceleton classes for: IntegratedStepperMotor and CageRotor, I do not have the hardware to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacement for: #267 discussed in #262
This pull request introduces drivers for the QCoDeS framework, enabling control of Thorlabs devices via the Thorlabs .NET API. The integration aims to provide a structured and extendable approach to instrument control within QCoDeS.
What's Included:
Current Status:
The API-structured classes are foundational but not complete. They can be expanded with more features and support for additional devices.
Further Information:
Detailed implementation notes can be found in the README at
...Thorlabs/private/DotNetAPI/README.md
.