Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Andor iDus/DU camera driver #334

Open
wants to merge 83 commits into
base: main
Choose a base branch
from

Conversation

thangleiter
Copy link
Contributor

@thangleiter thangleiter commented May 18, 2024

This PR significantly extends the capabilities of the Andor iDus camera driver. A fairly large part of the SDK is now covered.

Since the central data parameter, ccd_data, is dynamic in that it returns different shapes of arrays depending on the acqusition and read modes, I dropped the spectrum moniker. However, this also means that backwards compatibility is broken. If this is something we want to avoid, one could add a DelegateParameter that issues a deprecation warning when called.

To Do

  • Test hardware triggering
    Deferred to a later point in time.
  • acquired_pixels needs to be aware of downsampling that, e.g., image mode performs.
  • acquisition in kinetics mode with the cosmic ray filter turned on errors.
    This seems to be a camera feature, so users should handle it.

Missing Features / Needs testing

  • Live stream of the CCD data using the run till abort mode. This requires some async work, but would be nice to have since taking a single picture at a time (1 or 2d) has quite a lot of communication overhead, meaning the fastest update rate I could achieve was ~200 ms.
  • Shutter modes (feature not available on our camera)
  • More real-time filter modes (feature not available on our camera)

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 676 lines in your changes missing coverage. Please review.

Project coverage is 10.46%. Comparing base (2ad9601) to head (1eeb9e6).
Report is 229 commits behind head on main.

Files with missing lines Patch % Lines
...des_contrib_drivers/drivers/Andor/Andor_iDus4xx.py 0.00% 602 Missing ⚠️
...s_contrib_drivers/drivers/Andor/post_processing.py 0.00% 70 Missing ⚠️
src/qcodes_contrib_drivers/drivers/Andor/DU401.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
- Coverage   11.46%   10.46%   -1.00%     
==========================================
  Files         124      136      +12     
  Lines       16790    18417    +1627     
==========================================
+ Hits         1925     1928       +3     
- Misses      14865    16489    +1624     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thangleiter
Copy link
Contributor Author

I think this is ready to go for now. I'll postpone work on hardware triggers until I have more time.

Do we add a newspiece here in this repo as well?

@thangleiter thangleiter marked this pull request as ready for review August 23, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant