-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Andor iDus/DU camera driver #334
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
- Coverage 11.46% 10.46% -1.00%
==========================================
Files 124 136 +12
Lines 16790 18417 +1627
==========================================
+ Hits 1925 1928 +3
- Misses 14865 16489 +1624 ☔ View full report in Codecov by Sentry. |
I think this is ready to go for now. I'll postpone work on hardware triggers until I have more time. Do we add a newspiece here in this repo as well? |
This PR significantly extends the capabilities of the Andor iDus camera driver. A fairly large part of the SDK is now covered.
Since the central data parameter,
ccd_data
, is dynamic in that it returns different shapes of arrays depending on the acqusition and read modes, I dropped thespectrum
moniker. However, this also means that backwards compatibility is broken. If this is something we want to avoid, one could add aDelegateParameter
that issues a deprecation warning when called.To Do
Test hardware triggeringDeferred to a later point in time.
acquired_pixels
needs to be aware of downsampling that, e.g., image mode performs.acquisition in kinetics mode with the cosmic ray filter turned on errors.This seems to be a camera feature, so users should handle it.
Missing Features / Needs testing
run till abort
mode. This requires some async work, but would be nice to have since taking a single picture at a time (1 or 2d) has quite a lot of communication overhead, meaning the fastest update rate I could achieve was ~200 ms.