QCodes Driver SPECS Zurich #327
Conversation
| def UserOut_ValSet50(self, Output_value: np.float32): | ||
| self.n.UserOut_ValSet(50, Output_value) | ||
|
|
||
| def ThreeDSwp_SwpAcqChsSet(self, channelIndexes: np.array(int)): |
There was a problem hiding this comment.
Here you should probably use NDArray from numpy typing https://numpy.org/devdocs/reference/typing.html#numpy.typing.NDArray (remember to add the import at the top of the file)
You probably want something like NDArray[np.integer] or NDArray[np.int32] if you want a specific integer size
There was a problem hiding this comment.
I have changed the things you mentioned. In case you're confused as to why I have "nanonis-tramea-specs" once and "nanonis_tramea_specs" the other time, that's because the actual module name, as in in order to install it, is "nanonis-tramea-specs" and it is imported as "nanonis_tramea_specs". This is bad practice and will be changed soon.
|
@Diddleydope Thanks for the contribution. There are a few failures in the Automatic CI build. When we are building the docs we must be able to import the code. Since your code depends on a module that not explicitly installed you should add it here https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/main/docs/conf.py#L127 to tell Sphinx to mock the missing import. The type checking using mypy fails for a similar reason. src/qcodes_contrib_drivers/drivers/SPECS/Specs_Tramea.py:4:1: error: Cannot find implementation or library stub for module named "nanonis_tramea_specs" [import-not-found] You should tell mypy to ignore it here https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/main/pyproject.toml#L76 See comment inline for the numpy issue |
| set_cmd=self.UserOut_ValSet1, | ||
| get_cmd=self.Signals_ValGet24, |
There was a problem hiding this comment.
Can we directly use self.n attributes instead of defining individual functions for each channel?
set_cmd=partial(self.n.UserOut_ValSet, 1)
get_cmd=(self.n.Signals_ValGet(24, 1)[2])[0]To verify, is it intended that get_cmd=self.Signals_ValGet24 (specifically 24) for all OutputX parameters?
There was a problem hiding this comment.
I was unaware that you could write partial functions like this in python (this is my first project in python). This is clearly way better. And no, that is not intended, I must have accidentally done that. I will change this immediately. Thank you for the input!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 10.97% 10.91% -0.06%
==========================================
Files 132 133 +1
Lines 17540 17630 +90
==========================================
Hits 1925 1925
- Misses 15615 15705 +90 ☔ View full report in Codecov by Sentry. |
No description provided.