Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/playable node and Inactive Channel Check #303

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

EvieePy
Copy link
Member

@EvieePy EvieePy commented Jun 10, 2024

Description

Allows a Node to be passed to both Playable.search and Pool.fetch_tracks to search for the given query. If None is passed (Default) both of these methods act as they previously did.

This also adds:

Add the inactive_channel check to Player. The check dispatches the currently available wavelink_inactive_player event via Discord.py when a channel is deemed inactive.

An inactive channel is one where no real(non-bot) members are in the channel for a specified amount of played tracks. This differs from the current inactive_timeout which is a time based check on how long the player has not been playing, though they both work together.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

@EvieePy EvieePy changed the title Feature/playable node Feature/playable node and Inactive Channel Check Jun 10, 2024
@EvieePy EvieePy mentioned this pull request Jun 10, 2024
8 tasks
Copy link
Contributor

@AbstractUmbra AbstractUmbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one query, but it's not a blocker. :)

wavelink/node.py Show resolved Hide resolved
@EvieePy EvieePy merged commit f548a3b into main Jun 11, 2024
3 checks passed
@EvieePy EvieePy deleted the feature/playable-node branch June 11, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants