Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive design giraudremi92 branch #40

Merged

Conversation

giraudremi92
Copy link
Contributor

Add the Responsive behavior for Laptop screen, Tablet and mobile.
With some changes in CSS and React components
As described here : Add responsive behavior #19
#19

Is this related to an open issue?
#19

+++ Website ReadMe Review #17
Add Yarn install in the Readme File
#17

@krook
Copy link
Member

krook commented Aug 23, 2021

Thank you @giraudremi92!

I still see some issues when I resize in Chrome or test the mobile/tablet views. But those are things we can iterate on to improve. Merging.

@krook krook merged commit 49e0963 into Pyrrha-Platform:main Aug 23, 2021
@giraudremi92
Copy link
Contributor Author

@krook
Ok let me know the issues then i could maybe resolve them
Thank you

@krook
Copy link
Member

krook commented Aug 23, 2021

Very strange. When I built and ran your fork locally, it seemed like it still had some of the same issues as in production, but when I merged and it pushed a build to https://pyrrha-platform.org/ it shows correctly.

So, very nice job! It looks great.

@giraudremi92 giraudremi92 deleted the ResponsivDesign_GIRAUDREMI92_BRANCH branch August 23, 2021 15:20
@giraudremi92
Copy link
Contributor Author

Cool ! Thank you !
Indeed i didn't try to build it locally , i just tested it in serve mode so I can't tell.
With Js Framework sometimes it's hard to see the build version locally maybe your http local server or your cache ?
Ps : I guess the project is using Flask and I know pretty well this Backend Framework if you have some issues please let me know I ll glad to help ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants