-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Message._raw_data
#2670
Conversation
This reverts commit a779c6f.
Co-authored-by: Paillat <[email protected]> Signed-off-by: Timo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MessagePayload
is not a documented class. Please add the class to documentation.
Or maybe document it as |
Head branch was pushed to by a user without write access
|
It's done this way for |
Do we really need to store the raw message data publicly? |
Are you suggesting something like |
I'm skeptical about the necessity of this attribute |
This attribute is useful for handling transcripts and other cases where messages need to be stored. It doesn't matter to me if it's public or private, but I strongly recommend adding it. Users should be able to use it freely if they need to. |
I see how having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to raw_data
make private
Signed-off-by: Timo <[email protected]>
I can see value to adding it, but only as undocumented private field. |
Summary
This PR adds
Message.data
, which is useful for handling message data or creating transcripts.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.