Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user context command members having a None guild #2573

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix: user context command members having a None guild #2573

merged 2 commits into from
Sep 10, 2024

Conversation

plun1331
Copy link
Member

@plun1331 plun1331 commented Sep 9, 2024 •
edited
Loading

Summary

read the pr title idiot

pretty much just duplicates the behavior of the normal slash command member option (with the added bonus of caching now! yay!)

pre-(this fix) calls to display_avatar and similar attrs would fail on user-installed (and not guild-installed) apps because guild was None

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@plun1331 plun1331 requested a review from a team as a code owner September 9, 2024 20:06
@plun1331
Update CHANGELOG.md
0173c2b 
Signed-off-by: plun1331 <[email protected]>
@plun1331 plun1331 added bug Something isn't working priority: low Low Priority labels Sep 9, 2024
@plun1331 plun1331 enabled auto-merge (squash) September 9, 2024 21:29
@plun1331 plun1331 merged commit 646e51a into master Sep 10, 2024
32 of 33 checks passed
@plun1331 plun1331 deleted the fix-usercommand branch September 10, 2024 01:15
Dorukyum pushed a commit that referenced this pull request Sep 15, 2024
@plun1331 @Dorukyum
fix: user context command members having a None guild (#2573)
f03711f 
* fix: user context command member having a `None` guild

Signed-off-by: plun1331 <[email protected]>

* Update CHANGELOG.md

Signed-off-by: plun1331 <[email protected]>

---------

Signed-off-by: plun1331 <[email protected]>
@plun1331 plun1331 linked an issue Sep 26, 2024 that may be closed by this pull request
Accessing server-specific attributes of discord.Member with user apps causes an exception #2515
Closed
3 tasks
baribarton pushed a commit to baribarton/pycord-no-potential-reconnect that referenced this pull request Oct 24, 2024
@plun1331 @baribarton
fix: user context command members having a None guild (Pycord-Devel…
b69457b 
…opment#2573)

* fix: user context command member having a `None` guild

Signed-off-by: plun1331 <[email protected]>

* Update CHANGELOG.md

Signed-off-by: plun1331 <[email protected]>

---------

Signed-off-by: plun1331 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

Assignees
No one assigned
Labels
bug Something isn't working priority: low Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing server-specific attributes of discord.Member with user apps causes an exception
2 participants
@plun1331 @ChickenDevs