-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update dependencies #4617
Conversation
9c69c37
to
c7e9d3e
Compare
Hi @davidhewitt , the Reference: https://crates.io/crates/eyre/versions However, PyO3 has MSRV 1.63. What do you think I should do with eyre?
|
Thanks for this, we should keep MSRV at 1.63. So we should keep eyre to >= 0.6.8. There might be similar cases for the other packages? |
https://lib.rs is useful for choosing minimum versions. For example, we can view MSRV and download counts of |
53c88f4
to
a1c7213
Compare
As discussed, the dependencies have been limited to:
Note that not only ">=" have been updated, but "<" are also updated to address the limitations. |
Actually, I think it's probably better to let the upper bounds be the latest versions of the crates. As long as the lower bounds can build on MSRV and we haven't dropped extremely popular versions of the crates, it's best for the ecosystem if we support a wide range. Sorry to have not been clearer about the upper bounds! |
I.e. upper bounds should ideally be the latest major versions unless there's a very good reason not to support them. I think the upper bounds we had previously were probably fine? |
a1c7213
to
b80faf9
Compare
The upper bounds are reset. |
@davidhewitt feel free to merge if you consider it fine. Or happy to make changes if any comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me! Sorry for the delay, long week 😩
- eyre: 0.4 => 0.6.8 - hashbrown: 0.9 => 0.14.5 - indexmap: 1.6 => 2.5.0 - num-complex: 0.2 => 0.4.6 - chrono-tz: 0.6 => 0.10 Eyre min-version is limited to 0.6.8 to be compatible with MSRV 1.63 Hashbrown min-version is limited to 0.14.5: rust-lang/hashbrown#574 Indexmap min-version is limited to 2.5.0 to be compatible with hashbrown 0.14.5
b80faf9
to
1d52be0
Compare
deps: update dependencies
Eyre min-version is limited to 0.6.8 to be compatible with MSRV 1.63
Hashbrown min-version is limited to 0.14.5: rust-lang/hashbrown#574
Indexmap min-version is limited to 2.5.0 to be compatible with hashbrown 0.14.5