Fixed SDL Texture deadlock

Need to make sure to unlock always after locking
PureSwift · Nov 18, 2017 · 10688a8 · 10688a8
1 parent 086e738
commit 10688a8
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/Sources/SDL/Texture.swift b/Sources/SDL/Texture.swift
@@ -140,13 +140,15 @@ public final class Texture {
 
         var pixels: UnsafeMutableRawPointer? = nil
 
-        guard SDL_LockTexture(internalPointer, rectPointer, &pixels, &pitch) >= 0,
-            let pointer = pixels
+        guard SDL_LockTexture(internalPointer, rectPointer, &pixels, &pitch) >= 0
             else { return nil }
 
-        let result = try body(pointer, Int(pitch))
+        defer { SDL_UnlockTexture(internalPointer) }
+
+        guard let pointer = pixels
+            else { return nil }
 
-        SDL_UnlockTexture(internalPointer)
+        let result = try body(pointer, Int(pitch))
 
         return result
     }