Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] require c++11 as the minimum standard #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lrusak
Copy link
Contributor

@lrusak lrusak commented Oct 2, 2020

Introduced in #45 lambdas require a minimum of c++11 standard in order to build. This is needed because clang seems to default to c++98 by default. see, https://clang.llvm.org/cxx_status.html

cmake -DCMAKE_CXX_STANDARD=98 ..
make

results in failure

/home/lukas/Documents/git/platform/src/util/StringUtils.cpp: In static member function ‘static std::string& StringUtils::TrimLeft(std::string&)’:
/home/lukas/Documents/git/platform/src/util/StringUtils.cpp:456:99: warning: lambda expressions only available with ‘-std=c++11’ or ‘-std=gnu++11’
  456 |   str.erase(str.begin(), ::find_if(str.begin(), str.end(), [](char s) { return isspace_c(s) == 0; }));
      |                                                                                                   ^

This PR fixes this issue

@Hedda
Copy link

Hedda commented Jun 8, 2021

@malard @opdenkamp any updates on this?

@yol yol mentioned this pull request Mar 30, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants