PufferDepositor and access #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bxmmm1
commented
Feb 16, 2024
•
bxmmm1
commented
- Remove unused code from the PufferDepositor
- Create a helper script for access management
| bytes4[] memory publicSelectors = new bytes4[](6); | ||
| publicSelectors[0] = PufferVaultMainnet.withdraw.selector; | ||
| publicSelectors[1] = PufferVaultMainnet.redeem.selector; | ||
| publicSelectors[2] = PufferVaultMainnet.redeem.selector; |
There was a problem hiding this comment.
Why 2 selectors for redeem?
| @@ -189,6 +228,8 @@ contract PufferVaultMainnet is PufferVault { | |||
|
|
|||
| /** | |||
| * @notice Allows the `msg.sender` to burn his shares | |||
| * @dev Restricted to PufferProtocol smart contract | |||
| * We use it to burn the bond if the node operator gets slashed | |||
| * @param shares The amount of shares to burn | |||
| */ | |||
| function burn(uint256 shares) public restricted { | |||
There was a problem hiding this comment.
Nbd, but we mentioned we could allow anyone to call this to basically make a donation. The alternative they'd have is to send to something like address(0), but doesn't really burn the token / change the exchange ratio.
There was a problem hiding this comment.
Less things to think about. If somebody wants to donate, they can do so by depositing ETH/stETH/WETH
CheyenneAtapour
suggested changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.