Skip to content

L2 Minor changes

L2 Minor changes #171

Triggered via pull request May 31, 2024 10:05
@bxmmm1bxmmm1
synchronize #83
l2-pufETH-ben
Status Success
Total duration 1m 33s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
solhint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
solhint: src/NoImplementation.sol#L7
Explicitly mark visibility of state
solhint: src/NoImplementation.sol#L7
Immutable variables name are set to be in capitalized SNAKE_CASE
solhint: src/NoImplementation.sol#L15
GC: Use Custom Errors instead of require statements
solhint: src/PufferVaultV2.sol#L278
GC: Use Custom Errors instead of require statements
solhint: src/PufferVaultV2.sol#L303
GC: Use Custom Errors instead of require statements
solhint: src/PufferVaultV2.sol#L603
Avoid to use inline assembly. It is acceptable only in rare cases
solhint: src/PufferVaultV2.sol#L610
Avoid to use inline assembly. It is acceptable only in rare cases