Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nft Collections #536

Merged
merged 26 commits into from
Nov 11, 2022
Merged

Nft Collections #536

merged 26 commits into from
Nov 11, 2022

Conversation

ignaciosantise
Copy link
Contributor

Summary

  • Grouping nfts by collection
  • Converted nft modals into real screens
  • Unified modal stack
  • Refreshing cache when transfering/changing account/pull-to-refresh nfts
  • Improved nft video cache
  • Improved file types logic and extensions using mime-type
  • Made NFT component more generic, accepting styles as props

Screenshots

Android

android1.mp4
android2.mp4

iOS

ios1.MP4
ios2.MP4

Github Issue

#535

@ignaciosantise
Improved useGetType hook to type fetch only if needed
e2b9e1f
@ignaciosantise
Moved add collection components to modal folder, added refresh boolea…
d1f42b1 
…n when refreshing nft
@ignaciosantise
Moved components to TS, improving nft list
c32c743
@ignaciosantise
Updated reanimated lib
8d41157
@ignaciosantise
Added ntf list screen, improving nft component
0f2f790
@ignaciosantise
Improving nft displayer
9abf341
@ignaciosantise
Improved nft type handling, updated dab lib, changing screen title ac…
94ce7e0 
…cording to nft
@ignaciosantise
Updated flashlist lib
f7ff8a8
@ignaciosantise
Unified modal navigator
32eed01
@ignaciosantise
migrating nft detail to ts
1c31c28
@ignaciosantise
Merge branch '0.4.0' into nft-rebamp
a585b54
@ignaciosantise
Improving navigation typing]
714e62c
@ignaciosantise
fix detail screen, updated navigation lib
7f2a779
@ignaciosantise
Small change in search bar
0c660c8
@ignaciosantise
hiding back if detail is open directly
23c182b
@ignaciosantise
Code improvement
e59bc90
@ignaciosantise
Improving cache of nfts
c5043d4
@ignaciosantise
typecheck change
49b9047
@ignaciosantise
Updated svg lib
c0ce507
@ignaciosantise
Renamed nft component
a28c74c
@ignaciosantise
removed unused style, changed on nft press callback in send
892408b
@ignaciosantise
disabled send if loading icns data
283ed03
@ignaciosantise
Refreshing nft list when transfer
64c5690
mattgle
mattgle reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@mattgle mattgle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some comments tho

src/components/common/SearchBar/styles.ts Outdated Show resolved Hide resolved
src/screens/flows/Send/components/ReviewSend/styles.ts Outdated Show resolved Hide resolved
src/screens/tabs/NFTs/index.tsx Outdated Show resolved Hide resolved
src/screens/tabs/NFTs/index.tsx Outdated Show resolved Hide resolved
src/screens/tabs/NFTs/index.tsx Outdated Show resolved Hide resolved
src/screens/tabs/NFTs/screens/NftDetail/index.tsx Show resolved Hide resolved
src/screens/tabs/NFTs/screens/NftDetail/index.tsx Show resolved Hide resolved
src/screens/tabs/NFTs/screens/NftDetail/index.tsx Show resolved Hide resolved
src/screens/tabs/NFTs/styles.ts Outdated Show resolved Hide resolved
mattgle
mattgle approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@mattgle mattgle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work man! Looking really good!

@ignaciosantise ignaciosantise merged commit 37eff93 into 0.4.0 Nov 11, 2022
@ignaciosantise ignaciosantise deleted the nft-rebamp branch November 11, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgle mattgle mattgle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignaciosantise @mattgle