Support spec.keepAdjacent in joinForwards and joinBackwards #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect this to be ready to merge - just starting the conversation.
Some questions:
Any good ideas for spec property name? I've gone with
keepAdjacent
but I don't love it.Tests? I noticed there are no tests for the
isolating
spec property, so maybe you are OK without.Perhaps the deleteBarrier behaviour should only be suppressed if both the before and after nodes have
keepAdjacent
. Right now, backspace only checks the before node, and delete the after node.I assume a corresponding PR for prosemirror-model will be needed. It looks like this will only be to include the new spec property in the doc comment. Do you follow any protocol for keeping such things in sync across repos?