Remove incorrect Signer type (#460)

Remove incorrect custom Signer type
ProjectOpenSea · Jan 4, 2024 · 0c5ab56 · 0c5ab56
1 parent b44c250
commit 0c5ab56
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 24 deletions.
diff --git a/src/seaport.ts b/src/seaport.ts
@@ -6,6 +6,7 @@ import {
   JsonRpcProvider,
   Provider,
   JsonRpcSigner,
+  Signer,
 } from "ethers";
 import {
   SEAPORT_CONTRACT_NAME,
@@ -33,7 +34,6 @@ import type {
   OrderWithCounter,
   TipInputItem,
   MatchOrdersFulfillment,
-  Signer,
   ApprovalAction,
   CreateBulkOrdersAction,
   SeaportContract,

diff --git a/src/types.ts b/src/types.ts
@@ -1,4 +1,4 @@
-import { BigNumberish, BytesLike, ContractTransaction, ethers } from "ethers";
+import { BigNumberish, ContractTransaction } from "ethers";
 import { ItemType, OrderType } from "./constants";
 import type { TestERC20, TestERC721 } from "./typechain-types";
 import { TransactionMethods } from "./utils/usecase";
@@ -27,28 +27,6 @@ export type SeaportConfig = {
   };
 };
 
-type TypedDataDomain = {
-  name?: string;
-  version?: string;
-  chainId?: BigNumberish;
-  verifyingContract?: string;
-  salt?: BytesLike;
-};
-
-type TypedDataField = {
-  name: string;
-  type: string;
-};
-
-// Temporary until TypedDataSigner is added in ethers (in v6)
-export type Signer = ethers.Signer & {
-  _signTypedData(
-    domain: TypedDataDomain,
-    types: Record<string, Array<TypedDataField>>,
-    value: Record<string, any>,
-  ): Promise<string>;
-};
-
 export type OfferItem = {
   itemType: ItemType;
   token: string;