Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add transfer validator to v1 #115

Merged
merged 2 commits into from
Mar 29, 2024
Merged

add transfer validator to v1 #115

merged 2 commits into from
Mar 29, 2024

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Mar 27, 2024

No description provided.

@coveralls
Copy link

coveralls commented Mar 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8474809434

Details

  • 12 of 22 (54.55%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 59.375%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/ERC721TransferValidator.sol 5 6 83.33%
src/test/MockTransferValidator.sol 2 4 50.0%
src/clones/ERC721AConduitPreapprovedCloneable.sol 0 3 0.0%
src/clones/ERC721ContractMetadataCloneable.sol 0 4 0.0%
Totals Coverage Status
Change from base Build 8445548817: -0.9%
Covered Lines: 534
Relevant Lines: 744
💛 - Coveralls

@ryanio ryanio merged commit d1e305c into main Mar 29, 2024
8 checks passed
@ryanio ryanio deleted the ryan/v1-transfer-validator branch March 29, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanio @coveralls