cache transferValidator on stack

ProjectOpenSea · Apr 1, 2024 · fa28d22 · fa28d22
1 parent da36ee1
commit fa28d22
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/clones/ERC1155ContractMetadataCloneable.sol b/src/clones/ERC1155ContractMetadataCloneable.sol
@@ -354,9 +354,10 @@ contract ERC1155ContractMetadataCloneable is
     ) internal virtual override {
         if (from != address(0) && to != address(0)) {
             // Call the transfer validator if one is set.
-            if (_transferValidator != address(0)) {
+            address transferValidator = _transferValidator;
+            if (transferValidator != address(0)) {
                 for (uint256 i = 0; i < ids.length; i++) {
-                    ITransferValidator1155(_transferValidator).validateTransfer(
+                    ITransferValidator1155(transferValidator).validateTransfer(
                         msg.sender,
                         from,
                         to,

diff --git a/src/lib/ERC1155ContractMetadata.sol b/src/lib/ERC1155ContractMetadata.sol
@@ -352,9 +352,10 @@ contract ERC1155ContractMetadata is
     ) internal virtual override {
         if (from != address(0) && to != address(0)) {
             // Call the transfer validator if one is set.
-            if (_transferValidator != address(0)) {
+            address transferValidator = _transferValidator;
+            if (transferValidator != address(0)) {
                 for (uint256 i = 0; i < ids.length; i++) {
-                    ITransferValidator1155(_transferValidator).validateTransfer(
+                    ITransferValidator1155(transferValidator).validateTransfer(
                         msg.sender,
                         from,
                         to,

diff --git a/src/lib/ERC721ContractMetadata.sol b/src/lib/ERC721ContractMetadata.sol
@@ -314,8 +314,9 @@ contract ERC721ContractMetadata is
     ) internal virtual override {
         if (from != address(0) && to != address(0)) {
             // Call the transfer validator if one is set.
-            if (_transferValidator != address(0)) {
-                ITransferValidator721(_transferValidator).validateTransfer(
+            address transferValidator = _transferValidator;
+            if (transferValidator != address(0)) {
+                ITransferValidator721(transferValidator).validateTransfer(
                     msg.sender,
                     from,
                     to,