Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add window example #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeffreycwitt
Copy link
Collaborator

we don't actually need to pull this in, but I extended the working ui example to not only adde a manifest, but to add a window, and navigate forward and backwards.

In the process, I discovered the need to indicate the index of the image annotated on the canvas. If we don't want to hard code this to the 0 index position, I suggest adding an imageIndex to the default properties of the addWindow actions. I made that addition in this pull request.

Screen shot
image

@sdellis
Copy link
Collaborator

sdellis commented May 9, 2018

@jeffreycwitt That's a good call to add image index in as one of the values to the redux default state. As much as I like your additions to the UI, I'm not sure we want to add too much complexity to this PoC stage. Easier to track down bugs when there's less code. At any rate, I'll leave that up to @aeschylus .

@jeffreycwitt
Copy link
Collaborator Author

@sdellis oh I definitely agree. I didn't really mean for it to be pulled in. I just wanted to make another example.
You can close it.
jw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants