Stop streams automatically once dropped #14
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
commented
Jun 1, 2024
Comment on lines
+215
to
+224
| let path: Vec<_> = path.into_iter().map(|s| s.to_string()).collect(); | ||
| move || { | ||
| tokio::spawn(async move { | ||
| // TODO: Find a more elegant way to pass the path, ideally without | ||
| // converting back and forth between Vec<String>, Vec<&str> and &[&str] | ||
| let path: Vec<_> = path.iter().map(|s| &**s).collect(); |
There was a problem hiding this comment.
Implementation note: The (rather messy) second conversion would potentially be redundant with #15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a guard to streams that automatically issues a
STOPonce dropped.Implementing this required a rather major change to the implementation, namely wrapping the internal state into
Arc/Mutex/atomics to makeLighthousecloneable, since the stop guard requires keeping a reference to theLighthousealive (dynamically). This refactoring is implemented in thelh-shared-statebranch, which this PR is based upon.