-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduction of server side rendering #838
Merged
thescientist13
merged 19 commits into
release/0.23.0
from
feature/issue-708-server-side-rendering
Jan 14, 2022
Merged
introduction of server side rendering #838
thescientist13
merged 19 commits into
release/0.23.0
from
feature/issue-708-server-side-rendering
Jan 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
RFC
Proposal and changes to workflows, architecture, APIs, etc
CLI
SSR
discussion
tied to an ongoing discussion or meeting notes
feature
New feature or request
labels
Dec 28, 2021
thescientist13
force-pushed
the
feature/issue-708-server-side-rendering
branch
from
January 10, 2022 16:53
50cef7a
to
2c0c22d
Compare
This was referenced Jan 10, 2022
thescientist13
force-pushed
the
feature/issue-708-server-side-rendering
branch
from
January 14, 2022 01:51
2c0c22d
to
945ea56
Compare
27 tasks
thescientist13
added a commit
that referenced
this pull request
Feb 12, 2022
* initial introduction of server side rendering * update config spec * ESM cache busting in development with workers * correctly establish body and template support for SSR routes * basic metadata support * frontmatter and graph support * fix lint * basic smoke test case for SSR * fix and clean up specs * basic smoke testing with HTML optimization for server routes * handle pre-rendering for SSR routes * support SSR bundling * full frontmatter support and custom route data for SSR routes * document server rendering * add ssr mode to config docs * clarify serve command in README * ESM path to file interop for windows * rebase fixes * remove demo code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLI
discussion
tied to an ongoing discussion or meeting notes
documentation
Greenwood specific docs
feature
New feature or request
RFC
Proposal and changes to workflows, architecture, APIs, etc
SSR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #708 (extracted from #812)
Summary of Changes
mode
(ssr
mode "conflicts" with MPA mode, see TODOs section below)I think what's really cool about the possibilities here is how seamless it would be to run a hybrid application, such that you can have a set of static and dynamic pages and routes that can all share the same static resources, yet still feel like one app.
In this way
I tried to demonstrate that here in this PR with the "Artists" page, though obviously this will not work on Netlify, but you can try it locally!
yarn serve
localhost:8080/artists/
TODOs
getTemplate()
getContent()
getMetadata()
serve
commandserve
command(breaking) fluid "mode" / workspace configuration (autodetect based on pages, routes, etc)- have Greenwood auto detect project (mode) and expose client router option ("fluid" workspaces) #856(breaking)- makeprerender: false
by default and avoid puppeteer installprerender
config option false by default #855Need more in memory driven architecture / pipelines which will become more handy as part of serverless, for things like Rollup bundling for SSR- Serverless (+ single route builds) #626 (comment)Need to have some sort of in cached bundling for SSR? Check if it exists on filesystem instead of in a- Serverless (+ single route builds) #626 (comment)Map
for rollup bundling already bundled assets?why can't standard HTML just get all the data from the graph instead of all of this path finding stuff that was already done in the graph?- refactor html plugin serve to use graph to lookup files and content #854/artist/${id}
(post release?)