Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property Pass Restructuring #1021

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Conversation

ankit-privado
Copy link
Contributor

@ankit-privado ankit-privado commented Mar 19, 2024

This PR involves restructuring the PropertyLinkerPass for all languages. Below are the changes included in this PR:

  1. An abstract class named EnvPropertyLinkerPassBase has been introduced, which will be implemented by language-specific LinkerPasses. It includes common utility methods and property linker logic.
  2. The propertyLinkerPass has been renamed to EnvPropertyLinkerPass because we are handling the use case of linking literal nodes to environment properties.
  3. The yaml linker pass has been removed and merged with specific linker passes.
  4. Support for RubyEnvPropertyLinkerPass and its unit test has been added.
  5. AnnotationLinker is separated out from EnvLinker for Java.
  6. DBLinker is separated for Python.

@ankit-privado ankit-privado marked this pull request as ready for review March 26, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants