-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev additions #18
Open
mattkrau
wants to merge
36
commits into
master
Choose a base branch
from
dev-additions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev additions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request. We discussed most of it already in person, but for the record here are the most important points:
Regarding SRI
Regarding the generator tag
Regarding additional serverleaks
|
…i-for) - both style and script
…pmrc package.json workspace.yml
…rison with CVE-DB
…rison with CVE-DB
…pmrc package.json workspace.yml
…+ PEP8 compliance.
…omedevtools. Trying POC to confirm hypothesis.
…lesheet. Still not detected if hash is false
+ Started reworking result from list to dict
Added "all-sri-active-valid" key (defaulting to false) to quickly show whether all scripts/styles require sri and/or are both active and/or valid
… flag #enable-experimental-web-platform-features is enabled, it correctly throws an error if a script / style has no integrity-hash. This is now accounted for. + all-sri-active-valid is now evaluated and set correctly
- Reworked / removed unused code. - Speed up the module - Corrected behaviour if no errors were found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked about in the weekly meeting, rebased to master:
Adds following functionalities: