adds molecule, README to build dependencies #247
Conversation
added FQDN in the tasks Co-authored-by: Beck Davis <[email protected]> Co-authored-by: Denzil Phillips <[email protected]> Co-authored-by: Francis Kayiwa <[email protected]>
…g those tagged 'never' Co-authored-by: Alicia Cozine <[email protected]> Co-authored-by: Beck Davis <[email protected]> Co-authored-by: Francis Kayiwa <[email protected]>
add this role to the be tested on GH Actions
kayiwa
force-pushed
the
i244_build_dependencies
branch
from
34f8176
to
9037e1d
Compare
There was a problem hiding this comment.
I'm not sure how best to review these, is it useful/important to pull down and run molecule locally?
It looks like the build dependencies readme hasn't been filled out, and I see inconsistent licenses in various places (the repo-wide license and our default has been apache 2).
What is the new_role role for?
FYI we have a github actions for molecule tests but I disabled it because they were all failing. I suggest we re-enable it and then you all can update it and add roles to the list as you get them updated.
| License | ||
| ------- | ||
|
|
||
| BSD |
There was a problem hiding this comment.
we've been using apache 2
| Requirements | ||
| ------------ | ||
|
|
||
|
|
||
| Role Variables | ||
| -------------- | ||
|
|
||
|
|
||
| Dependencies | ||
| ------------ | ||
|
|
||
|
|
||
| Example Playbook | ||
| ---------------- | ||
|
|
||
| Including an example of how to use your role (for instance, with variables passed in as parameters) is always nice for users too: | ||
|
|
||
| - hosts: servers | ||
| roles: | ||
| - { role: username.rolename, x: 42 } |
There was a problem hiding this comment.
is this boiler plate that hasn't been filled in yet? even if no reqs/deps shouldn't we say that explicitly?
| company: Princeton University Library | ||
| description: build_dependencies | ||
| author: pulibrary |
There was a problem hiding this comment.
Should these be CDH? We could look at what we used before in the roles where we have added metadata - we should probably standardize if possible, although of course I want to give appropriate credit for PUL contributing to these ansible roles.
| description: build_dependencies | ||
| author: pulibrary | ||
|
|
||
| license: MIT |
There was a problem hiding this comment.
our default has been apache 2
added FQDN in the tasks