Refactor user badge component #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markocic
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Very good! One more thing that should be changed along with comments is that every usage of NostrUserText should be given legendaryCustomization if there is also an UniversalAvatarThumbnail with legendaryCustomization. Examples of this can be seen in MutedUserListItem.kt:129 and NotificationListItem.kt:406. Might be the only two places, if I haven't missed any.
...otlin/net/primal/android/premium/legend/custimization/LegendaryProfileCustomizationScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/net/primal/android/core/compose/NostrUserText.kt
Outdated
Show resolved
Hide resolved
markocic
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.