Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding data-test attribute #380

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: adding data-test attribute #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea874ea
feat: adding data-test attribute
guillaume60240 Oct 1, 2024
367cf37
Merge branch 'main' into feat-new-datatest
mattgoud Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/components/pagination/src/pagination-large.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,21 @@
:key="page"
:model-value="page"
:disabled="disabled"
:data-test="
dataTest != undefined ? `pageSelector-${dataTest}` : undefined
"
class="puik-pagination__select"
@update:model-value="emit('update:page', $event)"
>
<puik-option
v-for="index in maxPage"
:key="`puik-pagination__page-selector__option-${index}`"
:value="index"
:data-test="
dataTest != undefined
? `pageSelectorOption-${dataTest}-${index}`
: undefined
"
>
{{ index }}
</puik-option>
Expand Down
1 change: 1 addition & 0 deletions packages/components/table/src/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export interface TableProps {
fullWidth?: boolean
stickyFirstCol?: boolean
stickyLastCol?: boolean
dataTest?: string
}

export type TableEmits = {
Expand Down
111 changes: 103 additions & 8 deletions packages/components/table/src/table.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,20 @@
<table
class="puik-table"
:class="{ 'puik-table--full-width': fullWidth }"
:data-test="dataTest != undefined ? `table-${dataTest}` : undefined"
>
<thead class="puik-table__head">
<thead
class="puik-table__head"
:data-test="
dataTest != undefined ? `table-header-${dataTest}` : undefined
"
>
<tr>
<td :colspan="selectable || expandable ? headers.length +1 : headers.length">
<td
:colspan="
selectable || expandable ? headers.length + 1 : headers.length
"
>
<div class="puik-table__head-separator" />
</td>
</tr>
Expand All @@ -28,11 +38,21 @@
{ 'puik-table__head__row__item--selection': selectable },
{ 'puik-table__head__row__item--expandable': expandable },
]"
:data-test="
dataTest != undefined
? `table-header-th-${dataTest}-selection`
: undefined
"
>
<puik-checkbox
v-if="selectable && !searchBar"
:model-value="selectAll"
:indeterminate="indeterminate"
:data-test="
dataTest != undefined
? `table-header-checkbox-${dataTest}`
: undefined
"
class="puik-table__head__row__item--selection__checkbox"
@click="handleClickAll"
>
Expand Down Expand Up @@ -75,10 +95,21 @@
},
]"
:style="{ minWidth: header.width, width: header.width }"
:data-test="
dataTest != undefined
? `table-header-th-${dataTest}-${header.value}`
: undefined
"
>
<div class="puik-table__head__row__item__container">
<div class="puik-table__head__row__item__content">
<span>
<span
:data-test="
dataTest != undefined
? `table-header-content-${dataTest}-${header.value}`
: undefined
"
>
<slot
:name="`header-${header.value}`"
:header="header"
Expand All @@ -94,15 +125,32 @@
"
variant="primary-reverse"
size="sm"
:aria-label="sortIcon[header.value] === PuikTableSortIcon.Asc ? `${t('puik.table.sortableAscLabel')} ${header.value}` : sortIcon[header.value] === PuikTableSortIcon.Desc ? `${t('puik.table.sortableDescLabel')} ${header.value}` : `${t('puik.table.sortableDefaultLabel')} ${header.value}`"
:aria-label="
sortIcon[header.value] === PuikTableSortIcon.Asc
? `${t('puik.table.sortableAscLabel')} ${header.value}`
: sortIcon[header.value] === PuikTableSortIcon.Desc
? `${t('puik.table.sortableDescLabel')} ${header.value}`
: `${t('puik.table.sortableDefaultLabel')} ${
header.value
}`
"
:data-test="
dataTest != undefined
? `table-header-sort-${dataTest}-${header.value}`
: undefined
"
@click="sortTable(header.value)"
/>
</div>
</div>
</th>
</tr>
<tr>
<td :colspan="selectable || expandable ? headers.length +1 : headers.length">
<td
:colspan="
selectable || expandable ? headers.length + 1 : headers.length
"
>
<div class="puik-table__head-separator" />
</td>
</tr>
Expand All @@ -124,11 +172,21 @@
{ 'puik-table__head__row__item--selection': selectable },
{ 'puik-table__head__row__item--expandable': expandable },
]"
:data-test="
dataTest != undefined
? `table-header-th-${dataTest}-searchBar-selection`
: undefined
"
>
<puik-checkbox
v-if="selectable"
:model-value="selectAll"
:indeterminate="indeterminate"
:data-test="
dataTest != undefined
? `table-header-checkbox-${dataTest}-searchBar`
: undefined
"
class="puik-table__head__row__item--selection__checkbox"
@click="handleClickAll"
>
Expand Down Expand Up @@ -171,6 +229,11 @@
},
]"
:style="{ minWidth: header.width, width: header.width }"
:data-test="
dataTest != undefined
? `table-header-th-${dataTest}-${header.value}-searchBar`
: undefined
"
>
<template v-if="header.searchable || header.searchSubmit">
<div class="puik-table__head__row__item__container">
Expand All @@ -181,6 +244,11 @@
:search-submit="header.searchSubmit"
:search-reset="searchReset"
:search-type="(header.searchType as PuikTableSearchInputTypes)"
:data-test="
dataTest != undefined
? `${dataTest}-${header.value}`
: undefined
"
@search-text-value="handleSearch"
@search-range-value="handleSearch"
@search-submit-event="handleSearchSubmit"
Expand All @@ -192,12 +260,17 @@
</th>
</tr>
<tr v-if="searchBar">
<td :colspan="selectable ? headers.length +1 : headers.length">
<td :colspan="selectable ? headers.length + 1 : headers.length">
<div class="puik-table__head-separator" />
</td>
</tr>
</thead>
<tbody class="puik-table__body">
<tbody
class="puik-table__body"
:data-test="
dataTest != undefined ? `table-body-${dataTest}` : undefined
"
>
<template v-if="searchLoading">
<tr
v-for="(_item, rowIndex) in props.items"
Expand Down Expand Up @@ -244,6 +317,11 @@
v-if="selectable"
:model-value="getSelected(rowIndex)"
class="puik-table__body__row__item--selection__checkbox"
:data-test="
dataTest != undefined
? `table-body-checkbox-${rowIndex}-${dataTest}`
: undefined
"
@click="handleClick(rowIndex)"
>
{{ getSelectLabel(rowIndex) }}
Expand All @@ -256,6 +334,11 @@
]"
icon="keyboard_arrow_down"
font-size="24"
:data-test="
dataTest != undefined
? `table-body-icon-${rowIndex}-${dataTest}`
: undefined
"
@click="expandRow(rowIndex)"
@keydown.space.prevent="expandRow(rowIndex)"
/>
Expand Down Expand Up @@ -294,7 +377,14 @@
"
>
<div class="puik-table__body__row__item__container">
<div class="puik-table__body__row__item__content">
<div
class="puik-table__body__row__item__content"
:data-test="
dataTest != undefined
? `table-body-item-${rowIndex}-${header.value}-${dataTest}`
: undefined
"
>
<slot
:name="`item-${header.value}`"
:item="item"
Expand Down Expand Up @@ -337,6 +427,11 @@
: headers.length
"
class="puik-table__body__row__item puik-table__body__row__item--expanded"
:dataTest="
dataTest != undefined
? `table-body-expanded-${rowIndex}-${dataTest}`
: undefined
"
>
<slot
name="expanded-row"
Expand Down
Loading
Loading