MailTheme example module for PS8 #122
Conversation
0x346e3730
commented
Nov 8, 2022
•
0x346e3730
commented
| Questions | Answers |
|---|---|
| Description? | Upgrade the MailTheme example module for PS8. Needs PrestaShop/PrestaShop#30295. |
| Type? | refacto |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #108. |
| How to test? | Try the module and make sure it's working as intended. |
| Possible impacts? | mailtheme module only. |
|
Try to modify getTemplatePath |
0x346e3730
changed the title
|
Also needs PrestaShop/PrestaShop#30295 |
There was a problem hiding this comment.
Ok for me, let's wait for PrestaShop/PrestaShop#30295 to be merged
| @@ -1,4 +1,7 @@ | |||
| {% extends '@PrestaShop/Admin/layout.html.twig' %} | |||
| {% extends '@!PrestaShop/Admin/layout.html.twig' %} | |||
There was a problem hiding this comment.
I don't remember, what is the interest of the initial ! ?
There was a problem hiding this comment.
It's to be sure we use PrestaShop's template and not one from a module as it could lead to a infinite loop
|
The new constructor of the FolderThemeScanner class in this PR breaks this PR because of Edit : Fixed https://github.com/PrestaShop/example-modules/pull/122/files#diff-249c27b04b40dc32437d71beb17091c58b095da676a26a085bca04adfd1dc35eR230 but this PR now needs PrestaShop/PrestaShop#30295 to be merged first |
|
Hi @0x346e3730, I tested your module with the PR #30295 and currently we have some issue on it. as you can see : Untitled_.Dec.16.2022.11_44.AM.webm |
|
Hello @AureRita I am afraid the bug you observe is not related to the PR and the initial topic of the subject #108. I understand that it does prevent you from testing the PR, but @0x346e3730 cannot start working on #108 then on another bug PrestaShop/PrestaShop#30290 then on another found during QA testing, it's never going to end ^^ . The PR is going to grow, it will be more complex, will need git rebase and so on. So I discussed with @0x346e3730 and we pause this PR for now, he cannot continue this work as we have no idea when the list of bugs to fix will end. We don't know when (if) he will be able to dedicate time to this PR again. |
