add usePositionStickyObserver #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleek91
reviewed
Aug 18, 2023
brandonreid
force-pushed
the
addUseIsStickyStuck
branch
from
133fa6b
to
3a6ff64
Compare
brandonreid
force-pushed
the
addUseIsStickyStuck
branch
from
1439e76
to
8fcf97d
Compare
| } | ||
|
|
||
| const { observe } = useIntersectionObserver(intersect, computed(() => ({ | ||
| threshold: [1], |
There was a problem hiding this comment.
Does a hardcoded threshold make sense here? Asking cause I'm not sure how exactly it's used
There was a problem hiding this comment.
Yeah that's a key part of the hack (explained here). Tbh, I'm not 100% sure how it works under the hood.
pleek91
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to test this, but putting it up for early review.