Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dot-env-secrets recipe #265

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Conversation

lucianosrp
Copy link
Contributor

Description

What's cooking?
As discussed with @EmilRex, here is my first recipe to help loading enviroment variables from a .env file to a Prefect workspace using the Secret Block. Not sure where this should be in the repository.

Type of change

  • New feature (non-breaking change which adds functionality)

New Recipe Checklist

  • My PR is in the format of Add <project-name> recipe
  • My recipe is reproducible and explains everything needed to run successfully. If my code has external dependencies, I make mention of them.
  • My code is easily understandable and/or well-commented.
  • If my recipe requires a new category (e.g. creating a monitoring/ folder in devops/), I have encapsulated my project within its own subfolder so that others can add their own recipes as well.
  • If my recipe uses Prefect < 2.0, my code is within the prefect-v1-legacy/ folder.

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @lucianosrp - thank you for the contribution 😄

I think this is a cool example, I'm not sure this (load_secrets) needs to be a flow though

would you be open creating a new folder at the same level as flows-advanced called configuration or something? we were thinking of flows-advanced as a place for more advanced flow authoring strategies

flows-advanced/dot-env-secrets/README.md Outdated Show resolved Hide resolved
@lucianosrp
Copy link
Contributor Author

Hi @zzstoatzz , I agree! I really didn't know if it had to be a flow in order to be in this repository.
I like your idea and I will make this change! Thanks for having a look at it 🙏

Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for the contribution @lucianosrp !

@zzstoatzz zzstoatzz merged commit dc3a601 into PrefectHQ:main Mar 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants