forked from OpenCMISS/iron
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to analytic Jacobian #2
Open
jennyhelyanwe
wants to merge
12
commits into
PrasadBabarendaGamage:finite-elasticity-fixes
Choose a base branch
from
jennyhelyanwe:analytic-jacobian
base: finite-elasticity-fixes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes to analytic Jacobian #2
jennyhelyanwe
wants to merge
12
commits into
PrasadBabarendaGamage:finite-elasticity-fixes
from
jennyhelyanwe:analytic-jacobian
+95
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap dependency detection for static builds only.
Add newlines to the iron-config-dependencies.cmake file
…nite-elasticity-fixes
Multiply appropriate scale factors to the Jacobian values.
Negative volume changes now show up with a warning flag with details on the element number and gauss point number at which this occurs, and also the det(F) value.
Two scale factors need to be multiplied to the Jacobian term instead of just one (compare with two commits ago). This current correction gives same number of iterations as FD method, and an approximately 5.5 times speed up for an LV inflation example.
Under equations jacobian matrices calculation type, two methods of evaluating the Jacobian is exposed: finite differences, and analytic. The analytic version only works for the Guccione equation currently. To toggle the Jacobian methods, use equations.JacobianMatricesTypeSet(), with the available types: iron.EquationsJacobianCalculated.FINITE_DIFFERENCE or iron.EquationsJacobianCalculated.ANALYTIC
Immediate after evaluating the deformation gradient tensor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surface pressure Jacobian fix (add correct scale factors)
Added function to select for finite differences or analytic Jacobian methods (equations.JacobianMatricesTypeSet) and made two more constants public: iron.EquationsJacobianCalculated.FINITE_DIFFERENCES, and iron.EquationsJacobianCalculated.ANALYTIC.
Add warning message for negative volumes for gauss points.