Fix issues with module name and external help file metadata #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
force-pushed
the
BugFixesv1
branch
from
80049b1 to
7834071
Compare
adityapatwardhan
changed the title
# in the output type# in the output type and allow hyphen in module name
daxian-dbw
approved these changes
Jun 18, 2021
adityapatwardhan
changed the title
# in the output type and allow hyphen in module name
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #529
Fixes #515
Fixes #447
fixes #528
The
#character has to be escaped when converted to YAML as anything after a # is considered a comment.Change the way the file is determined to be a module page file by checking the yaml metadata header instead of relying on
-in the file name.Added tests.
Also fix the metadata for external help file when command is in a nested module.