NuGetApiKey is required for nuget based gallery service #463
Conversation
Removed _ValidateNotNullOrEmpty_ from NugetApiKey and implemented checking for the parameter in Publish-Module and Publish-PSArtifactUtility similar to how credentials are added conditionally.
|
|
| $ArgumentList += '-NonInteractive' | ||
| if ($PSBoundParameters.Containskey('NugetApiKey')) { | ||
| $ArgumentList += @('--api-key', "`"$NugetApiKey`"") |
There was a problem hiding this comment.
Nuget.exe doesn't have an argument --api-key, stick with -apikey
* fix prerelease behavior * these tests are intermittently failing on appveyor (networking issues?) * delete unused file * autoformat; add -ErrorAction to some tests to get better info * fix skip syntax * extra debug info * fix count and add more debug info
* facilitate easier local development * update readme file
- A few of localization strings for the DSC resource PSModule was revised to be more descriptive and fixed typos. One localization string was removed as it was not used.
* Reusing Tags caused using the Length property to be used like an array instead of string * Added EnforceMaximumTagLength switch on Publish-Module to limit tags to 4000 characters * Renamed EnforceMaximumTagLength to SkipAutomaticTags * Keep Tags as string array and make new variable for a space separated string
|
@heidarj I'm pretty sure the argument to nuget.exe I call out above is wrong, but otherwise this should be fine. Let us know if you have time to update? |
…erShell#479) * fix new-nugetpackage to cope with more output from child process * address PR feedback
|
@edyoung I implemented the localized NuGetApiKeyIsRequiredForNuGetBasedGalleryService error message for when an API key is not specified so that it now throws the same error as before, if the repo you are pushing to requires an API key. Please let me know if any further changes are needed, otherwise I am good with this as is. |
|
Thanks! I think it's still a problem to pass --api-key when calling nuget, because it doesn't support the -- based parameter form. Also looks like the branch needs to be rebased or merged to match what's currently in development. If it's possible to fix that will happily merge. |
Removed _ValidateNotNullOrEmpty_ from NugetApiKey and implemented checking for the parameter in Publish-Module and Publish-PSArtifactUtility similar to how credentials are added conditionally.
Hey, I would like to submit my attempt at fixing the problem described in issue #143
I removed the ValidateNotNullOrEmpty check from the NugetApiKey parameter and implemented
ifstatements checking for the parameter in Publish-Module and Publish-PSArtifactUtility when constructing parameters, in the same way credentials are added conditionally.I ran tests on my machine after making the changes and got the following results:
Most of the failures were related to the dotnet cli tool, I have version 3.0.0 preview installed and imagine that might be conflicting.
With this change the cmdlet fails if no apikey is passed, in the same way as if an invalid apikey is passed, with a 403 status code from the API.