Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Command Error Handling #277

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Native Command Error Handling #277

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
717787c
Added Native Command Error Handling
theJasonHelmick Feb 9, 2021
1fa25ed
Merge branch 'master' of https://github.com/PowerShell/PowerShell-RFC…
theJasonHelmick Mar 22, 2021
5d04d21
updated demo.txt and spec
theJasonHelmick Mar 22, 2021
a985804
Update 1-Draft/RFC00XX-Native-Command-Error-Handling.md
theJasonHelmick Mar 23, 2021
c03f3df
Update 1-Draft/RFC00XX-Native-Command-Error-Handling.md
theJasonHelmick Mar 23, 2021
1a38126
Update 1-Draft/RFC00XX-Native-Command-Error-Handling.md
theJasonHelmick Mar 23, 2021
d29e4c3
Update 1-Draft/RFC00XX-Native-Command-Error-Handling.md
theJasonHelmick Mar 23, 2021
77f46e2
Update 1-Draft/RFC00XX-Native-Command-Error-Handling.md
theJasonHelmick Mar 23, 2021
bef6778
Update 1-Draft/RFC00XX-Native-Command-Error-Handling.md
theJasonHelmick Mar 23, 2021
fce539d
Update 1-Draft/RFC00XX-Native-Command-Error-Handling.md
theJasonHelmick Mar 23, 2021
e274268
updated post Jim review
theJasonHelmick Mar 23, 2021
177a002
Apply suggestions from code review
theJasonHelmick Mar 23, 2021
98a1055
cleaned demo.txt
theJasonHelmick Mar 23, 2021
ac7edb8
added bash/powershell demo clarity
theJasonHelmick Mar 23, 2021
15f408d
improved demo.txt
theJasonHelmick Mar 27, 2021
84b263b
changed $PSNativeCommandErrorAction to boolean
theJasonHelmick Mar 27, 2021
6fb05cd
changed $PSNativeCommandErrorAction to $PSNativeCommandUseErrorAction…
theJasonHelmick Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions 1-Draft/RFC00XX-Native-Command-Error-Handling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,9 +255,9 @@ Line |
> equivalent to the existing PowerShell `Set-StrictMode` and does not need to be addressed in this
> RFC.

### $PSNativeCommandErrorAction
### $PSNativeCommandUseErrorActionPreference

The `$PSNativeCommandErrorAction` preference variable will be implemented as a boolean.
The `$PSNativeCommandUseErrorActionPreference` preference variable will be implemented as a boolean.

- When enabled (1), `$ErrorActionPreference` will affect native commands with described behavior.
- When disabled (0), `$ErrorActionPreference` will have no effect to the original behavior.
Expand All @@ -282,8 +282,8 @@ The reported error record object will be the new type: `NativeCommandException`
### Preference variable resolves error handling conflicts

In cases where an existing script already handles non-zero native command errors, the preference
variable `$PSNativeCommandErrorAction` may be set to `$false`. Error handling behavior of the
PowerShell cmdlets is handled separately with `$ErrorActionPreference`.
variable `$PSNativeCommandUseErrorActionPreference` may be set to `$false`. Error handling behavior
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this name longer seems like the wrong direction to go. Also, if it ends in ActionPreference then I would expect it to be of type [System.Management.Automation.ActionPreference] instead of [bool].

Copy link

@ceztko ceztko Apr 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the variable being boolean and the name ending with Preference sounds weird. The name is so long that Use gets lost while reading. PSNativeCommandErrorActionEnabled, PSEnableNativeCommandErrorAction may better highlight the implicit type of the variable. Still they are long names, though.

of the PowerShell cmdlets is handled separately with `$ErrorActionPreference`.

## Alternative Approaches and Considerations

Expand Down